chore: bump seldon charm 1.15 -> 1.17.1 for CKF release 1.8 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
force-pushed
the
kf-3887-bump-seldon-charm-for-ckf-1.8
branch
from
99e70a3
to
fdfac84
Compare
orfeas-k
force-pushed
the
kf-3887-bump-seldon-charm-for-ckf-1.8
branch
2 times, most recently
from
29cb441
to
d586a83
Compare
orfeas-k
force-pushed
the
kf-3887-bump-seldon-charm-for-ckf-1.8
branch
2 times, most recently
from
0766a79
to
d148470
Compare
orfeas-k
force-pushed
the
kf-3887-bump-seldon-charm-for-ckf-1.8
branch
from
d148470
to
32c2854
Compare
NohaIhab
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Thanks @orfeas-k for the great effort
Added a few comments
I tried to use the e2e test from the UATs to verify, but it failed for me where the SeldonDeployment is in Failed state.
SeldonDeployment status and state:
status:
address:
url: http://kf-testing-wine-model.admin.svc.cluster.local:8000/api/v1.0/predictions
conditions:
- lastTransitionTime: "2023-10-16T09:29:08Z"
reason: Not all services created
status: "False"
type: Ready
- lastTransitionTime: "2023-10-16T09:29:08Z"
reason: Not all services created
status: "False"
type: ServicesReady
description: no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1"
state: Failed
Are there any changes we need to make to the test?
orfeas-k
force-pushed
the
kf-3887-bump-seldon-charm-for-ckf-1.8
branch
from
3bda8cb
to
18c69a2
Compare
NohaIhab
approved these changes
Oct 19, 2023
NohaIhab
added a commit
that referenced
this pull request
Oct 19, 2023
update tox.ini's update-requirements (#215) Updates tox.ini's update-requirements as described in canonical/argo-operators#100 Ref canonical/kubeflow-ci#59 doc link (#214) tests(integration): Apply seldondeployments in namespace `default` (#220) * tests(integration): Refactor Refactor integration tests after hitting issue #218. This is a workaround for the issue. At the same time, it is needed to revert those back since up until now, integration tests were applying seldondeployments to the namespace created by Juju. In production, this would be `kubeflow` and we would never apply something there. * tests(integration): Rename DEFAULT_NAMESPACE to WORKLOADS_NAMESPACE Contributing (#219) Co-authored-by: Orfeas Kourkakis <orfeas.kourkakis@canonical.com> chore: bump seldon charm 1.15 -> 1.17.1 for CKF release 1.8 (#216) * bump seldon-core-operator 1.15.0 -> 1.17.1 for CKF 1.8 * manifests: Update CRD according to upstream manifests * manifests: Update manifests roles names * Use upstream images 1.17.1 for seldon servers * tests(unit): Modify expected pebble plan * tests(integration): Update expected huggingface output * tests(integration): Update expected mlserver-mlflow output * contributing.md: Add update manifests instructions * gitignore: Ignore venv directory reqs: refresh requirements-integration.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump seldon-core-operator charm from 1.15 -> 1.17.1. See #221 for details.
This PR also brings changes that we missed/skipped during update when we udpated it for CKF 1.7. Note that we still do not follow everything that upstream does (they do not apply some of the manifests we do and let the operator do everything). This should be a different effort since the charm will need some refactoring.
Closes #221
Update
We will not do a refactoring to the charm since this is not technically possible at the moment. See #222 for details