Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump mlserver-huggingface for Seldon version 1.15.x -> 1.17.1 #66

Merged
merged 15 commits into from
Jan 9, 2024

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Dec 7, 2023

Update ROCK according to upstream changes but also:

Details for changes in #37.
Closes #54

@orfeas-k orfeas-k marked this pull request as ready for review December 8, 2023 11:43
@orfeas-k orfeas-k requested a review from a team as a code owner December 8, 2023 11:43
ca-scribner
ca-scribner previously approved these changes Dec 8, 2023
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, apart from a minor comment.

I see the CI is failing during the scan due to lack of disk space. This might be resolved if the build step and scan step are not part of the same job (I think build leaves behind some extra artifacts)

@orfeas-k orfeas-k enabled auto-merge (squash) January 9, 2024 16:33
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@orfeas-k orfeas-k merged commit 1061ede into main Jan 9, 2024
3 checks passed
@orfeas-k orfeas-k deleted the kf-5018-update-huggingface branch January 9, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rockraft file of mlserver-huggingface for CKF 1.8
2 participants