Remove flask dependency api layer #373
Conversation
|
Starting demo at: http://snapcraft.io-pr-373.run.demo.haus/ |
Lukewh
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
| "JSON decoding failed: ", | ||
| str(decode_error), | ||
| ]) | ||
| raise InvalidResponseContent(error_message) |
There was a problem hiding this comment.
Nitpicking on style, the string-joining looks strange:
error_message = 'JSON decoding failed: {}'.format(decode_error)
| ]) | ||
| raise InvalidResponseContent(error_message) | ||
|
|
||
| if details_response.status_code != 200: |
There was a problem hiding this comment.
The store API uses other 2xx status and they should be treated as success.
|
|
||
| if details_response.status_code != 200: | ||
| if 'error_list' in details: | ||
| api_error_exception = ApiErrorResponse("Error list") |
There was a problem hiding this comment.
You might get some expiration from https://git.launchpad.net/snapdevicegw/tree/snapdevicegw/exceptions.py and have a chain of exceptions that would treat the API errors internally, APIError(error_response)
| if api_error_exception.errors: | ||
| flask.abort(api_error_exception.status, api_error_exception.errors) | ||
| else: | ||
| flask.abort(api_error_exception.status, ["Unknown error"]) |
There was a problem hiding this comment.
It doesn't seem to be a good idea to blindly 'leak' snap-details error status to you own application, nor leaking bad-json responses to ugly 500s to the app users. Wouldn't it be possible to tolerate errors and carry on with details = {...} ?
Refactoto S02E01 - The first Endpoint
Summary
QA
./run./run test