Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unauthenticated agreement acceptance issue #4575

Merged
merged 1 commit into from Apr 4, 2024

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Apr 4, 2024

Done

Fix an error where the user agreement wasn't able to be accepted

How to QA

Issue / Card

Fixes #4572

@webteam-app
Copy link

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.25%. Comparing base (4f03970) to head (45155da).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4575       +/-   ##
===========================================
+ Coverage   67.61%   79.25%   +11.64%     
===========================================
  Files         113      207       +94     
  Lines        3659    10645     +6986     
  Branches      945      945               
===========================================
+ Hits         2474     8437     +5963     
- Misses       1061     2084     +1023     
  Partials      124      124               
Flag Coverage Δ
javascript 67.61% <ø> (ø)
python 85.35% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steverydz steverydz marked this pull request as ready for review April 4, 2024 14:23
Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@steverydz steverydz merged commit 31e82cd into canonical:main Apr 4, 2024
10 checks passed
@steverydz steverydz deleted the fix-agreement-accept-bug branch April 4, 2024 15:13
steverydz added a commit to steverydz/snapcraft.io that referenced this pull request Apr 5, 2024
steverydz added a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer Programme Agreement - Internal server error
3 participants