Skip to content

Commit

Permalink
extensions: improve comments for desktop-launch scripts (#4250)
Browse files Browse the repository at this point in the history
Added comments to indicate where the desktop-launch script comment comes
from for the gnome extension with core22 and later
  • Loading branch information
kenvandine committed Jul 6, 2023
1 parent fc985d4 commit 36cc6f7
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 12 deletions.
9 changes: 6 additions & 3 deletions extensions/desktop/common/desktop-exports
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
#!/bin/bash
###############################################
# Launcher common exports for any desktop app #
###############################################
###########################################################
# Launcher common exports for any desktop app
# This is not used with the gnome extension for
# core22 and later, please see
# https://github.com/snapcore/snapcraft-desktop-integration
###########################################################

# Note: We avoid using `eval` because we don't want to expand variable names
# in paths. For example: LD_LIBRARY_PATH paths might contain `$LIB`.
Expand Down
6 changes: 6 additions & 0 deletions extensions/desktop/common/fonts
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
#!/bin/bash

###########################################################
# This is not used with the gnome extension for
# core22 and later, please see
# https://github.com/snapcore/snapcraft-desktop-integration
###########################################################

set -e

[ ! -d "${SNAP_COMMON}/fontconfig" ] && mkdir -p "${SNAP_COMMON}/fontconfig"
Expand Down
9 changes: 6 additions & 3 deletions extensions/desktop/common/init
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
#!/bin/bash
#################
# Launcher init #
#################
###########################################################
# Launcher init
# This is not used with the gnome extension for
# core22 and later, please see
# https://github.com/snapcore/snapcraft-desktop-integration
###########################################################

# shellcheck disable=SC2034
START=$(date +%s.%N)
Expand Down
9 changes: 6 additions & 3 deletions extensions/desktop/common/mark-and-exec
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
#!/bin/bash
###############################
# Mark update and exec binary #
###############################
###########################################################
# Mark update and exec binary
# This is not used with the gnome extension for
# core22 and later, please see
# https://github.com/snapcore/snapcraft-desktop-integration
###########################################################

# shellcheck disable=SC2154
[ "$needs_update" = true ] && echo "SNAP_DESKTOP_LAST_REVISION=$SNAP_REVISION" > "$SNAP_USER_DATA/.last_revision"
Expand Down
9 changes: 6 additions & 3 deletions extensions/desktop/gnome/launcher-specific
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
#!/bin/bash
##############################
# GTK launcher specific part #
##############################
###########################################################
# GTK launcher specific part
# This is not used with the gnome extension for
# core22 and later, please see
# https://github.com/snapcore/snapcraft-desktop-integration
###########################################################

# shellcheck disable=SC2154
if [ "$wayland_available" = true ]; then
Expand Down

0 comments on commit 36cc6f7

Please sign in to comment.