Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of assert_not_called in the catkin tests #200

Merged
merged 1 commit into from Jan 5, 2016
Merged

Replace use of assert_not_called in the catkin tests #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions snapcraft/tests/test_plugin_catkin.py
View file
Open in desktop
Expand Up @@ -304,7 +304,8 @@ def __eq__(self, args):

bashrun_mock.assert_called_with(check_build_command())

self.dependencies_mock.assert_not_called(
self.assertFalse(
self.dependencies_mock.called,
'Dependencies should have been discovered in the pull() step')

finish_build_mock.assert_called_once_with()
Expand Down Expand Up @@ -342,7 +343,8 @@ def __eq__(self, args):

bashrun_mock.assert_called_with(check_pkg_arguments(self))

self.dependencies_mock.assert_not_called(
self.assertFalse(
self.dependencies_mock.called,
'Dependencies should have been discovered in the pull() step')

finish_build_mock.assert_called_once_with()
Expand Down Expand Up @@ -459,7 +461,8 @@ def test_finish_build(self, run_output_mock, run_mock):
self.assertEqual(f.read(), '#!/usr/bin/env python',
'The shebang was not replaced as expected')

self.dependencies_mock.assert_not_called(
self.assertFalse(
self.dependencies_mock.called,
'Dependencies should have been discovered in the pull() step')

@mock.patch.object(catkin.CatkinPlugin, 'run')
Expand Down