lifecycle: automatically stage dependencies #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take the following situation: we have two parts, `A` and `B`. `A` depends on `B` by way of having `after: [B]`. Today, if one runs `snapcraft pull A`, the snapcraft CLI errors out complaining that it needs to stage `B` first, requiring one to run `snapcraft pull A B`. Not only is this an error, it's a `RuntimeError`, causing a traceback. Stop erroring in this situation, and just stage `B` like the user wants. Fixes SNAPCRAFT-10 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
feature/auto_build_dependencies
branch
from
f522e06
to
98221c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2144 +/- ##
==========================================
+ Coverage 91.02% 91.03% +<.01%
==========================================
Files 193 193
Lines 12182 12178 -4
Branches 1820 1817 -3
==========================================
- Hits 11089 11086 -3
- Misses 751 752 +1
+ Partials 342 340 -2
Continue to review full report at Codecov.
|
sergiusens
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh unit?Take the following situation: we have two parts,
AandB.Adepends onBby way of havingafter: [B]. Today, if one runssnapcraft pull A, the snapcraft CLI errors out complaining that it needs to stageBfirst, requiring one to runsnapcraft pull A B. Not only is this an error, it's aRuntimeError, causing a traceback.This PR fixes LP: #1774018 by no longer erroring in this situation, and just staging
Blike the user wants.