project_loader: allow loading null parts #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to specify remote parts without requiring the use of `after`, which implies a relationship which may not exist. LP: #1772027 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Codecov Report
@@ Coverage Diff @@
## master #2153 +/- ##
==========================================
+ Coverage 91.3% 91.31% +<.01%
==========================================
Files 193 193
Lines 12165 12167 +2
Branches 1812 1813 +1
==========================================
+ Hits 11107 11110 +3
Misses 715 715
+ Partials 343 342 -1
Continue to review full report at Codecov.
|
sergiusens
approved these changes
Jun 4, 2018
brlin-tw
added a commit
to brlin-tw/snapcrafters-template-plus
that referenced
this pull request
Sep 6, 2018
Since Snapcraft 2.43 it is possible to include a remote part without specify it in a part's `after` value. This allows parts that not actually depend on each other from being bond together by dependency , for example build step of yad part being cleaned due to change in desktop-gtk3. Refer-to: Bug #1772027 “Pull stage of an unspecified part is unexpectedly cleaned by snapcraft” : Bugs : Snapcraft <https://bugs.launchpad.net/snapcraft/+bug/1772027> Refer-to: project_loader: allow loading null parts by kyrofa · Pull Request #2153 · snapcore/snapcraft <canonical/snapcraft#2153> Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
brlin-tw
added a commit
to brlin-tw/poedit
that referenced
this pull request
Nov 28, 2018
Prefer this new syntax introduced in Snapcraft 2.43 to avoid the cleaning of the poedit part due to the modification of the desktop-gtk3 part. Refer: canonical/snapcraft#2153
brlin-tw
added a commit
to brlin-tw/qxmledit
that referenced
this pull request
Dec 22, 2018
Since Snapcraft 2.43 it's now possible to specify building a part without listing it in an existing part's after clause, which may cause the depending part unnecessarily cleaned due to the dependency. Refer canonical/snapcraft#2153 for more info about the syntax. Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
vslavik
pushed a commit
to vslavik/poedit
that referenced
this pull request
Jan 11, 2019
Prefer this new syntax introduced in Snapcraft 2.43 to avoid the cleaning of the poedit part due to the modification of the desktop-gnome-part part. Refer: canonical/snapcraft#2153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh unit?This PR fixes LP: #1772027 by allowing one to specify remote parts without requiring the use of
after, which implies a relationship which may not exist. With this PR, one can specify that the want a remote part simply by listing the part name, e.g.: