Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

many: extract lifecycle ordering into own module #2159

Merged
merged 9 commits into from
Jun 12, 2018
Merged

many: extract lifecycle ordering into own module #2159

merged 9 commits into from
Jun 12, 2018

Commits on Jun 7, 2018

  1. many: extract lifecycle ordering into own module 

    Currently the snapcraft CLI has step names and ordering hard-coded in a
number of places, and those areas where it isn't hard-coded, a
difficult-to-read index method is used. Simplify and extract this logic
into a single module used by the others to determine lifecycle steps and
ordering.

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
    @kyrofa
    kyrofa committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    6595b9d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. Merge remote-tracking branch 'origin/master' into feature/refactor_li… 

    …fecycle_steps
    @kyrofa
    kyrofa committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    9cc60af View commit details
    Browse the repository at this point in the history

  2. steps: use linked list for ordering 

    Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
    @kyrofa
    kyrofa committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    ddf5445 View commit details
    Browse the repository at this point in the history

  3. steps: move back to single list 

    Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
    @kyrofa
    kyrofa committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    ceed729 View commit details
    Browse the repository at this point in the history

  4. steps: add automatically clean if dirty attribute 

    Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
    @kyrofa
    kyrofa committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    c4e43d6 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2018

  1. lxd: accept Step to clean 

    Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
    @kyrofa
    kyrofa committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    028f652 View commit details
    Browse the repository at this point in the history

  2. steps: remove qualifiers from Step __repr__ 

    Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
    @kyrofa
    kyrofa committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    d6ec4ea View commit details
    Browse the repository at this point in the history

  3. cli: use step_name as the option name in clean 

    Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
    @kyrofa
    kyrofa committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    db42639 View commit details
    Browse the repository at this point in the history

  4. Use steps.Step when handling duplicates 

    Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
    @kyrofa
    kyrofa committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    aa44ec3 View commit details
    Browse the repository at this point in the history