tests: add lifecycle ordering tests

snapcraft/internal/lifecycle/_clean.py

@@ -42,8 +42,10 @@ def _clean_part(part_name, step, config, staged_state, primed_state):
 
 def mark_dependents_dirty(part_name, cleaned_step, config):
     dependent_part_names = config.parts.get_reverse_dependencies(part_name)
-    dependent_parts = {p for p in config.all_parts
-                       if p.name in dependent_part_names}
+
+    # Keep ordering
+    dependent_parts = [p for p in config.all_parts
+                       if p.name in dependent_part_names]
 
     dirty_part_names = set()
     for part in dependent_parts:

tests/unit/lifecycle/__init__.py

@@ -0,0 +1,52 @@
+# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*-
+#
+# Copyright (C) 2015-2018 Canonical Ltd
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import fixtures
+import logging
+import textwrap
+
+import snapcraft
+from snapcraft.internal import project_loader
+from tests import unit
+
+
+class LifecycleTestBase(unit.TestCase):
+
+    def setUp(self):
+        super().setUp()
+
+        self.fake_logger = fixtures.FakeLogger(level=logging.INFO)
+        self.useFixture(self.fake_logger)
+        self.project_options = snapcraft.ProjectOptions()
+
+    def make_snapcraft_project(self, parts, snap_type=''):
+        yaml = textwrap.dedent("""\
+            name: test
+            version: 0
+            summary: test
+            description: test
+            confinement: strict
+            grade: stable
+            {type}
+
+            {parts}
+            """)
+
+        self.snapcraft_yaml_file_path = self.make_snapcraft_yaml(
+            yaml.format(parts=parts, type=snap_type))
+        project = snapcraft.project.Project(
+            snapcraft_yaml_file_path=self.snapcraft_yaml_file_path)
+        return project_loader.load_config(project)