-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add spread suite for cmake plugin #2183
tests: add spread suite for cmake plugin #2183
Conversation
86c9b01
to
97d88e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2183 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 201 201
Lines 12898 12898
Branches 1912 1912
=======================================
Hits 11767 11767
Misses 768 768
Partials 363 363 Continue to review full report at Codecov.
|
Move the plugin and snapd integration tests for the CMake plugin into a Spread suite. LP: #1783830 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
97d88e8
to
5ad3d32
Compare
@@ -1,11 +1,12 @@ | |||
name: cmake-hello | |||
version: 0.1 | |||
version: 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is missing quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, fixed.
summary: test the cmake plugin | ||
description: | | ||
This is a basic cmake snap. It just prints a hello world. | ||
If you want to add other functionalities to this snap, please don't. | ||
Make a new one. | ||
icon: icon.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, we do not need icons :-)
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
./runtests.sh static
?./runtests.sh unit
?This PR resolves LP: #1783830 by moving the plugin and snapd integration tests for the CMake plugin into a Spread suite.