kernel plugin: install .config as config-$kernelversion #2207
Conversation
Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2207 +/- ##
==========================================
+ Coverage 91.17% 91.18% +0.01%
==========================================
Files 202 202
Lines 12987 12991 +4
Branches 1921 1921
==========================================
+ Hits 11841 11846 +5
Misses 777 777
+ Partials 369 368 -1
Continue to review full report at Codecov.
|
| @@ -531,3 +531,8 @@ def do_install(self): | |||
| os.path.join(self.installdir, "lib", "firmware"), self.installdir | |||
| ) | |||
| os.rmdir(os.path.join(self.installdir, "lib")) | |||
| # install .config as config-$version | |||
| config = "config-{}".format(self.kernel_release) | |||
| config_path = os.path.join(self.installdir, config) | |||
There was a problem hiding this comment.
how about installing it under (self.installdir, "snap", config)? This way it sits together with every other manifesty thing.
There was a problem hiding this comment.
it sits next to the Symbols file with the above code and also matches where the config lives in the deb based kernel snaps, if we change it to go to the other dir, we should change the deb based snap builds alongside for consistency.
There was a problem hiding this comment.
ok, maybe the change should be globally planned then, I will leave it up to you to consolidate in a planned manner :-)
In Ubuntu classic we ship the kernel config as config-$kernelversion in /boot, and the same we do for kernel snaps available in the store: they contain the kernel config file as config-$kernelversion in the root of the kernel snap.
Unfortunately the kernel plugin never shipped the .config used to build the kernel, so fix it by installing it as config-$kernelversion in the root of the freshly generated kernel snap.
This fixes LP1786190
Signed-off-by: Paolo Pisati p.pisati@gmail.com