Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for scons plugin #2208

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Aug 9, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783843 by moving the plugin and snapd integration tests for the SCons plugin into a Spread suite.

Move the plugin and snapd integration tests for the SCons plugin into a
Spread suite.

LP: #1783843

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
plugin: scons
source: .
scons-options:
- --prefix=/
build-packages: [gcc, libc6-dev]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is libc6-dev really needed explicitly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check, honestly, I just assumed so since this is only a slight modification of an existing test.

@codecov-io
Copy link

codecov-io commented Aug 10, 2018

Codecov Report

Merging #2208 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2208   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files         202      202           
  Lines       12988    12988           
  Branches     1922     1922           
=======================================
  Hits        11843    11843           
  Misses        777      777           
  Partials      368      368

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10139a4...a31990b. Read the comment docs.

@kyrofa kyrofa merged commit a0d0297 into canonical:master Aug 10, 2018
@kyrofa kyrofa deleted the feature/1783843/scons_plugin_spread branch August 10, 2018 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants