Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: update requests #2402

Merged
merged 4 commits into from Nov 15, 2018
Merged

packaging: update requests #2402

merged 4 commits into from Nov 15, 2018

Conversation

sergiusens
Copy link
Collaborator

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@5fd36e5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2402   +/-   ##
=========================================
  Coverage          ?   90.22%           
=========================================
  Files             ?      195           
  Lines             ?    12784           
  Branches          ?     1938           
=========================================
  Hits              ?    11535           
  Misses            ?      852           
  Partials          ?      397

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd36e5...9249485. Read the comment docs.

Copy link
Contributor

@chipaca chipaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this madness!? No, definitely not.

Sorry that was a typo. I meant 'yes'.

@sergiusens sergiusens merged commit 12d0aad into canonical:master Nov 15, 2018
@sergiusens sergiusens deleted the requests branch November 15, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants