Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove obsolete snap and external tests #2421

Merged
merged 5 commits into from Dec 13, 2018

Conversation

sergiusens
Copy link
Collaborator

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@zyga
Copy link
Contributor

zyga commented Dec 7, 2018

Less code, what is not to like!

@codecov-io
Copy link

codecov-io commented Dec 7, 2018

Codecov Report

Merging #2421 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
- Coverage    90.1%   90.09%   -0.02%     
==========================================
  Files         196      196              
  Lines       12891    12886       -5     
  Branches     1956     1956              
==========================================
- Hits        11615    11609       -6     
- Misses        876      877       +1     
  Partials      400      400
Impacted Files Coverage Δ
snapcraft/internal/pluginhandler/_plugin_loader.py 82.65% <0%> (-2.05%) ⬇️
snapcraft/plugins/nodejs.py 90.25% <0%> (-0.31%) ⬇️
snapcraft/internal/elf.py 80.82% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d7dbcf...6d037f8. Read the comment docs.

@sergiusens
Copy link
Collaborator Author

unrelated plainbox failures, merging.

@sergiusens sergiusens merged commit 7073955 into canonical:master Dec 13, 2018
@sergiusens sergiusens deleted the docopt-- branch December 13, 2018 14:43
@kyrofa
Copy link
Contributor

kyrofa commented Feb 2, 2019

This broke so many docs :'( .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants