Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix usage string in help command #2429

Merged
merged 1 commit into from Dec 20, 2018

Conversation

felicianotech
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

LP: https://bugs.launchpad.net/snapcraft/+bug/1745040
Forum: https://forum.snapcraft.io/t/snapcraft-help-command-showing-wrong-usage/9045?u=felicianotech

P.S. The last two items in the checklist above, aren't documented well in the HACKING guide and don't even pass on master.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e9ae8d2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2429   +/-   ##
=========================================
  Coverage          ?   90.02%           
=========================================
  Files             ?      196           
  Lines             ?    12902           
  Branches          ?     1959           
=========================================
  Hits              ?    11615           
  Misses            ?      886           
  Partials          ?      401
Impacted Files Coverage Δ
snapcraft/cli/help.py 90.69% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ae8d2...3a5f8f9. Read the comment docs.

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@sergiusens sergiusens merged commit ab10346 into canonical:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants