Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanity_checks: fix sanity check on Windows #2919

Merged
merged 1 commit into from
Feb 10, 2020
Merged

sanity_checks: fix sanity check on Windows #2919

merged 1 commit into from
Feb 10, 2020

Conversation

NickZ
Copy link

@NickZ NickZ commented Feb 7, 2020 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

The sanity checks for expected snap directories were not checking to see if the path had backslashes in it, so the sanity check was failing on Windows. This fixes it.

cjp256
cjp256 approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I wonder if it should be using os.sep... since it's just a warning it doesn't really matter.

Thanks!

@NickZ NickZ marked this pull request as ready for review February 8, 2020 09:09
@sergiusens sergiusens merged commit cc40d5f into canonical:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens approved these changes

@cjp256 cjp256 cjp256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickZ @sergiusens @cjp256