Pre release unit test fix for 2.2 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This considers builder environment variables that could potentially affect unit tests. Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
|
Tested before (with failure) and after the fix with: |
|
Confirmed here that the test fails without this change, and passes with it. |
come-maiz
added a commit
that referenced
this pull request
Feb 10, 2016
Pre release unit test fix for 2.2
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
Signed-off-by: Brendan Dixon <brendand@microsoft.com>
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Pre release unit test fix for 2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This considers builder environment variables that could potentially affect
unit tests.
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com