Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: use prefix in store name registration hint #3213

Merged
merged 1 commit into from Jul 14, 2020
Merged

cli: use prefix in store name registration hint #3213

merged 1 commit into from Jul 14, 2020

Conversation

sergiusens
Copy link
Collaborator

Snapcraft recommended to register - to overcome
concerns about ownership of a given name. It was agreed a while ago to
prefix the username suggestion to have a common namespace for a
publisher for ordering/listing.

Minor updates to quoting were also done.

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@sergiusens
cli: use prefix in store name registration hint
43eaa85 
Snapcraft recommended to register <snap-name>-<username> to overcome
concerns about ownership of a given name. It was agreed a while ago to
prefix the username suggestion to have a common namespace for a
publisher for ordering/listing.

Minor updates to quoting were also done.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens added the bug Actual bad behavior that don't fall into maintenance or documentation label Jul 14, 2020
@cjp256
Copy link
Contributor

cjp256 commented Jul 14, 2020 •
edited

Related LP bug: https://bugs.launchpad.net/bugs/1886223 @galgalesh

cjp256
cjp256 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlijn-sebrechts
Copy link
Contributor

merlijn-sebrechts commented Jul 14, 2020 •
edited

Note for this pr specifically: it might be useful to also remove the line about renaming snaps, since that's not possible at the moment

As said in #1886223; given the issues we've had with snaps like arduino-mhall119, I don't think snapcraft should recommend pre/suffixing the username of the packager simply because they are not the upstream.

  • These snaps always need aliases, increasing the load on the review team.
  • Snaps can still be called whatever they want in the GUI storefronts.
  • Once upstream or another user takes over maintenance of the snap, the name of the snap becomes incorrect.
  • Or alternatively, you get another "orphaned" snap like arduino-mhall119.
  • The docs already ask not not include the name of the publisher in the snap.
  • Multiple people in the forum recommend against pre/suffixing usernames.

@sergiusens
Copy link
Collaborator Author

@galgalesh thanks for the insight, I will bring this up while syncing with the Snap Store team to see if this can actually push for renames.

@sergiusens sergiusens merged commit 3b0d87f into master Jul 14, 2020
@sergiusens sergiusens deleted the register-name branch July 14, 2020 20:51
abitrolly pushed a commit to abitrolly/snapcraft that referenced this pull request Mar 31, 2021
@sergiusens @abitrolly
cli: use prefix in store name registration hint (canonical#3213)
6768107 
Snapcraft recommended to register <snap-name>-<username> to overcome
concerns about ownership of a given name. It was agreed a while ago to
prefix the username suggestion to have a common namespace for a
publisher for ordering/listing.

Minor updates to quoting were also done.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjp256 cjp256 cjp256 approved these changes

Assignees
No one assigned
Labels
bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sergiusens @cjp256 @merlijn-sebrechts