build providers: use PEP-440 compliant version comparison operator #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're using PEP-440 compliant versioning, use the version objects provided by pkg_resources for comparison. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
added
tooling
bug
sergiusens
approved these changes
Jul 14, 2020
abitrolly
pushed a commit
to abitrolly/snapcraft
that referenced
this pull request
Mar 31, 2021
…anonical#3215) Now that we're using PEP-440 compliant versioning, use the version objects provided by pkg_resources for comparison. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're using PEP-440 compliant versioning, use the version
objects provided by pkg_resources for comparison.
Signed-off-by: Chris Patterson chris.patterson@canonical.com
./runtests.sh static?./runtests.sh tests/unit?