Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins v2: use repo.Repo not repo.Ubuntu in colcon #3257

Merged
merged 1 commit into from Aug 21, 2020
Merged

Conversation

cjp256
Copy link
Contributor

@cjp256 cjp256 commented Aug 21, 2020

References to "Ubuntu" breaks on non-Ubuntu systems.

Signed-off-by: Chris Patterson chris.patterson@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@cjp256 cjp256 added the Bug Actual bad behavior that don't fall into maintenance or documentation label Aug 21, 2020
References to repo.Ubuntu break on non-Ubuntu systems on import.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
@sergiusens sergiusens merged commit 31731cc into master Aug 21, 2020
@sergiusens sergiusens deleted the colcon-repo branch August 21, 2020 16:55
abitrolly pushed a commit to abitrolly/snapcraft that referenced this pull request Mar 31, 2021
References to repo.Ubuntu break on non-Ubuntu systems on import.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants