Copy entire source, even if source-subdir is specified. #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrofa
force-pushed
the
bugfix/1549676/source_subdir_still_copy_all
branch
from
92a5e00
to
45667dc
Compare
| tmpdir = tempfile.TemporaryDirectory() | ||
| self.addCleanup(tmpdir.cleanup) | ||
| plugin.builddir = tmpdir.name | ||
| self.assertEqual(os.path.join(plugin.buildbasedir, |
There was a problem hiding this comment.
It seems there will be less indentation eyeball matching if done like
self.assertEqual(
os.path.join(plugin.buildbasedir, options.source_subdir),
plugin.builddir)
|
I am 👍 but would really like those cosmetics fixed as I have difficulties aligning if it is too deep 😉 |
|
Easy changes! I'll keep that in mind for the future-- I've always tried to stretch the line as far as it'll go but you're right, it has its limits. Thanks for the review 😃 . |
Currently, if source-subdir is specified, Snapcraft copies ONLY that subdir (and excludes the rest of the source) and attempts to build from it. This only works for some projects, not all. A better solution is to copy the entire source and simply build from WITHIN the subdir. That is the change introduced here. LP: #1549676 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
bugfix/1549676/source_subdir_still_copy_all
branch
from
45667dc
to
6beb6fe
Compare
|
Grr... over quota or some such thing... |
|
retest this please |
1 similar comment
|
retest this please |
|
Tested locally-- examples pass. |
kyrofa
pushed a commit
that referenced
this pull request
Feb 29, 2016
…l_copy_all Copy entire source, even if source-subdir is specified.
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
Exceptions thrown from rdma processing thread running in the background were not logged properly. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
…bdir_still_copy_all Copy entire source, even if source-subdir is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if source-subdir is specified, Snapcraft copies ONLY that subdir (and excludes the rest of the source) and attempts to build from it. This only works for some projects, not all. A better solution is to copy the entire source and simply build from WITHIN the subdir. This PR fixes LP: #1549676 by introducing exactly that change. It does so without changing the plugin API or semantics.