Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker image instructions #3499

Merged
merged 4 commits into from Apr 16, 2021
Merged

Conversation

abitrolly
Copy link
Contributor

Leave only relevant details and mention how to specify Ubuntu version

Addresses #2673 (comment)

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With or without the suggestions, +1

docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Apr 15, 2021

Codecov Report

Merging #3499 (3a1be8c) into master (405c576) will not change coverage.
The diff coverage is n/a.

❗ Current head 3a1be8c differs from pull request most recent head b0d48d3. Consider uploading reports for the commit b0d48d3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3499   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files         276      276           
  Lines       18826    18826           
=======================================
  Hits        17121    17121           
  Misses       1705     1705           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405c576...b0d48d3. Read the comment docs.

abitrolly and others added 4 commits April 15, 2021 08:54
Leave only relevant details and mention how to specify Ubuntu version

Addresses canonical#2673 (comment)
Co-authored-by: Chris Patterson <cjp256@gmail.com>
Co-authored-by: Chris Patterson <cjp256@gmail.com>
@abitrolly
Copy link
Contributor Author

Rebased.

@sergiusens sergiusens merged commit 226da60 into canonical:master Apr 16, 2021
@abitrolly abitrolly deleted the patch-4 branch April 17, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants