Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers: refactor capture_logs_from_instance() #3935

Merged
merged 1 commit into from Oct 5, 2022

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 5, 2022

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Refactor capture_logs_from_instance():

  • Use new craft-providers call temporarily_pull_file()
  • Move method to snapcraft/providers/providers.py

Similar to rockcraft

(CRAFT-1307)

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@sergiusens sergiusens enabled auto-merge (squash) October 5, 2022 14:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #3935 (554336f) into main (f6abc2e) will increase coverage by 0.09%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3935      +/-   ##
==========================================
+ Coverage   91.07%   91.17%   +0.09%     
==========================================
  Files          60       59       -1     
  Lines        4134     4123      -11     
==========================================
- Hits         3765     3759       -6     
+ Misses        369      364       -5     
Impacted Files Coverage Δ
snapcraft/parts/lifecycle.py 88.71% <ø> (-0.05%) ⬇️
snapcraft/providers/providers.py 78.37% <33.33%> (-21.63%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens merged commit d0da7f8 into canonical:main Oct 5, 2022
@mr-cal mr-cal deleted the craft-providers-get-logs branch October 5, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants