Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: update craft-parts to 1.21.0 #4183

Merged
merged 5 commits into from Jun 6, 2023

Conversation

cmatsuoka
Copy link
Contributor

Craft Parts 1.21.0 add callbacks to explicitly list base packages
and to configure the overlay package layer.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests need updating for this to take into account pyproject.toml

Craft Parts 1.21.0 add callbacks to explicitly list base packages
and to configure the overlay package layer.

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
@cmatsuoka
Copy link
Contributor Author

Rebased on main.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Merging #4183 (8766d53) into main (c0c608b) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4183   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files         569      569           
  Lines       43746    43746           
=======================================
  Hits        41078    41078           
  Misses       2668     2668           
Impacted Files Coverage Δ
tests/unit/parts/plugins/test_python_plugin.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens merged commit 7cde068 into canonical:main Jun 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants