-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kde-neon-extension: remove extra build environment variables that are… #4193
kde-neon-extension: remove extra build environment variables that are… #4193
Conversation
… causing build failures.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4193 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 569 569
Lines 43746 43746
=======================================
Hits 41078 41078
Misses 2668 2668
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I tested this here canonical/gazebo_snap@06d1e77 and it worked as expected, compared with snapcore:main branch where it fails in the build stage due to pkgconfig errors. |
@ScarlettGatelyMoore @lengau could one of you fix the out-of-date so this can be merged? |
done |
remove extra build environment variables that are causing build failures.
… causing build failures.
make lint
?pytest tests/unit
?These build env variables are causing builds to fail in weird ways. Just remove them and let snapcrafters set them themselves.