Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde-neon-extension: remove extra build environment variables that are… #4193

Merged

Conversation

ScarlettGatelyMoore
Copy link
Contributor

… causing build failures.

  • [x ] Have you followed the guidelines for contributing?
  • [x ] Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

These build env variables are causing builds to fail in weird ways. Just remove them and let snapcrafters set them themselves.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #4193 (238bcc6) into main (d8930f1) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4193   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files         569      569           
  Lines       43746    43746           
=======================================
  Hits        41078    41078           
  Misses       2668     2668           
Impacted Files Coverage Δ
snapcraft/extensions/kde_neon.py 100.00% <ø> (ø)
tests/unit/extensions/test_kde_neon.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MirkoFerrati
Copy link
Contributor

I tested this here canonical/gazebo_snap@06d1e77 and it worked as expected, compared with snapcore:main branch where it fails in the build stage due to pkgconfig errors.
But I cannot guarantee it will work for all use-cases, the snapcraft.yaml I am using is quite complex and may hide corner cases.

@MirkoFerrati
Copy link
Contributor

MirkoFerrati commented Jun 13, 2023

@ScarlettGatelyMoore @lengau could one of you fix the out-of-date so this can be merged?

@ScarlettGatelyMoore
Copy link
Contributor Author

@ScarlettGatelyMoore @lengau could one of you fix the out-of-date so this can be merged?

done

@mr-cal mr-cal merged commit df5476b into canonical:main Jun 16, 2023
12 checks passed
mr-cal pushed a commit that referenced this pull request Jun 29, 2023
remove extra build environment variables that are causing build failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants