extensions: plugin aware part_snippet values #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sergiusens
force-pushed
the
work/CRAFT-1863-part-pluing-aware-extensions
branch
from
25fb027
to
08ec500
Compare
mr-cal
approved these changes
Jul 12, 2023
|
LGTM. Looks like some of the unit tests need to be updated too. |
4 tasks
Extend the API to take a plugin_name, for legacy do the same, but as an optional method in the base class. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
work/CRAFT-1863-part-pluing-aware-extensions
branch
from
08ec500
to
2a58620
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4271 +/- ##
==========================================
- Coverage 88.98% 88.96% -0.02%
==========================================
Files 296 295 -1
Lines 20192 20153 -39
==========================================
- Hits 17967 17930 -37
+ Misses 2225 2223 -2
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Fixed #4255 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the API to take a plugin_name, for legacy do the same, but as an optional method in the base class.
make lint?pytest tests/unit?