Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spread): make ros linter test less strict #4369

Merged
merged 3 commits into from Sep 21, 2023
Merged

test(spread): make ros linter test less strict #4369

merged 3 commits into from Sep 21, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 20, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

This spread test is now less strict but still verifies that:

  1. libpng library warning is filtered
  2. ros2-humble library warnings are not filtered

Fixes #4256
(CRAFT-1872)

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested a review from tigarmo September 20, 2023 16:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #4369 (1ae07ec) into main (b357ef5) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #4369      +/-   ##
==========================================
- Coverage   89.11%   89.09%   -0.03%     
==========================================
  Files         318      317       -1     
  Lines       21165    21116      -49     
==========================================
- Hits        18862    18814      -48     
+ Misses       2303     2302       -1     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal merged commit 8d0c451 into main Sep 21, 2023
13 checks passed
@mr-cal mr-cal deleted the ros-spread-test branch September 21, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve check for library linter in the ROS tests
4 participants