Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pyproject): quote versions #4423

Merged
merged 1 commit into from Oct 27, 2023
Merged

chore(pyproject): quote versions #4423

merged 1 commit into from Oct 27, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 25, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

X.Y versions in a pyproject.toml need to be quoted to avoid being treated as an integer to avoid warnings like this:

 pyproject.toml: [mypy]: python_version: Python 3.1 is not supported (must be 3.4 or higher). You may need to put quotes around your Python version

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested a review from a team October 25, 2023 19:38
@mr-cal mr-cal requested a review from a team October 25, 2023 20:27
@mr-cal mr-cal merged commit e3b8a3a into main Oct 27, 2023
9 of 10 checks passed
@mr-cal mr-cal deleted the pyproject-quotes branch October 27, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants