feat: improve lifecycle messages #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmatsuoka
approved these changes
Oct 31, 2023
|
@cmatsuoka I copied them from craft application! |
tigarmo
reviewed
Nov 1, 2023
sergiusens
force-pushed
the
better-messages
branch
from
9977439
to
28be157
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4431 +/- ##
=======================================
Coverage 89.17% 89.18%
=======================================
Files 321 321
Lines 21658 21655 -3
=======================================
- Hits 19314 19312 -2
+ Misses 2344 2343 -1
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
mr-cal
approved these changes
Nov 7, 2023
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
better-messages
branch
from
28be157
to
ba00727
Compare
This was referenced Nov 17, 2023
1 task
syu-w
pushed a commit
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?