Colcon plugin: use release build by default #4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirkoFerrati
commented
Jan 4, 2024
MirkoFerrati
force-pushed
the
feature/ros_colcon_release_build
branch
from
950f960
to
b522214
Compare
MirkoFerrati
commented
Jan 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4502 +/- ##
=======================================
Coverage 89.20% 89.20%
=======================================
Files 321 321
Lines 21755 21759 +4
=======================================
+ Hits 19407 19411 +4
Misses 2348 2348 ☔ View full report in Codecov by Sentry. |
artivis
reviewed
Jan 5, 2024
MirkoFerrati
force-pushed
the
feature/ros_colcon_release_build
branch
from
b522214
to
7a266a5
Compare
Guillaumebeuzeboc
approved these changes
Jan 5, 2024
artivis
approved these changes
Jan 5, 2024
|
@mr-cal Can we get an approval for the CI? |
mr-cal
approved these changes
Jan 5, 2024
|
Should this be also backported to 7.x? |
|
@cmatsuoka no need to backport |
syu-w
pushed a commit
that referenced
this pull request
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?But I got a strange error even if everything seems ok or 10/10
pytest tests/unit?But I failed one test with the same issue as reported here extensions: method to get data dir #3810
Normally Colcon does not set any build flags and leaves the choice to the user, meaning the default value is empty and uses the default cmake configuration for debug symbols and optimization.
Inside snaps the executables are not supposed to be debugged and should be as optimized as possible so we want the default to be "Release" explicitly, unless the user overrides it intentionally in their snapcraft.yaml
This PR has been tested by creating snaps of the simple ros2-talker-listener snap with different debug levels, either default or user-customized.
The results for the talker executable show a clear reduction in size and in the number of symbols.