New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(remote): reword git error messages #4536

Merged

mr-cal merged 1 commit into hotfix/8.0 from remote-build-git-error

Jan 25, 2024

Collaborator

mr-cal commented Jan 24, 2024

Have you followed the guidelines for contributing?
Have you signed the CLA?
Have you successfully run tox run -m lint?
Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Tasks

reword errors and link to documentation
create a git repo in the remote-build spread tests (already done in Spread update #4529)
update documentation with git repo requirement (https://snapcraft.io/docs/remote-build)
update snapcraft 8 release notes with git repo requirement (https://github.com/snapcore/snapcraft/releases/tag/8.0.0)

Fixes #4517
(CRAFT-2387)


          style(remote): reword git error messages

90231ec

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

mr-cal requested review from cmatsuoka and syu-w

January 24, 2024 15:54

syu-w approved these changes

View reviewed changes

cmatsuoka approved these changes

View reviewed changes

snapcraft/remote/git.py Show resolved Hide resolved

mr-cal merged commit bc1c553 into hotfix/8.0

9 of 10 checks passed

mr-cal deleted the remote-build-git-error branch

January 25, 2024 13:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment