Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use VersionStr in model and add write test #4626

Merged

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@sergiusens sergiusens requested review from lengau and mr-cal March 1, 2024 15:22
@sergiusens sergiusens force-pushed the fix-project-and-test-write-metadata branch from d8c3f99 to a012494 Compare March 1, 2024 17:00
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens force-pushed the fix-project-and-test-write-metadata branch from a012494 to 4f09926 Compare March 1, 2024 17:50
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.15%. Comparing base (6ff3e0b) to head (4f09926).
Report is 28 commits behind head on feature/craft-application.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/craft-application    #4626      +/-   ##
=============================================================
+ Coverage                      88.83%   89.15%   +0.32%     
=============================================================
  Files                            327      332       +5     
  Lines                          22033    22125      +92     
=============================================================
+ Hits                           19573    19726     +153     
+ Misses                          2460     2399      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiusens sergiusens merged commit a65f875 into feature/craft-application Mar 1, 2024
8 of 11 checks passed
@sergiusens sergiusens deleted the fix-project-and-test-write-metadata branch March 1, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants