feat(docs): pull in content from craft-parts #4635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4635 +/- ##
=======================================
Coverage 88.35% 88.35%
=======================================
Files 327 327
Lines 21997 21997
=======================================
Hits 19436 19436
Misses 2561 2561 ☔ View full report in Codecov by Sentry. |
tigarmo
force-pushed
the
CRAFT-2537-plugin-doc-details
branch
from
0669bad
to
d40d350
Compare
tigarmo
force-pushed
the
CRAFT-2537-plugin-doc-details
branch
from
34dd3c2
to
547e453
Compare
tigarmo
commented
Mar 7, 2024
tigarmo
force-pushed
the
CRAFT-2537-plugin-doc-details
branch
3 times, most recently
from
22f2566
to
0f2a624
Compare
syu-w
approved these changes
Mar 7, 2024
sergiusens
reviewed
Mar 7, 2024
sergiusens
approved these changes
Mar 7, 2024
tigarmo
force-pushed
the
CRAFT-2537-plugin-doc-details
branch
from
0f2a624
to
90a139c
Compare
This commit adds some reference & explanation content from craft-parts to snapcraft's docs. Note that unfortunately we need to add the single image file images/lifecycle_logic.png explicitly because the link is hardcoded in the source.
tigarmo
force-pushed
the
CRAFT-2537-plugin-doc-details
branch
from
90a139c
to
c2d8e79
Compare
4 tasks
lengau
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)