feat(core22): maven plugin #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4657 +/- ##
==========================================
+ Coverage 88.35% 88.37% +0.02%
==========================================
Files 327 328 +1
Lines 21997 22046 +49
==========================================
+ Hits 19435 19483 +48
- Misses 2562 2563 +1 ☔ View full report in Codecov by Sentry. |
tigarmo
requested changes
Mar 13, 2024
tests/spread/plugins/craft-parts/build-and-run-hello/maven-hello/snap/snapcraft.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
syu-w
approved these changes
Mar 13, 2024
mattculler
approved these changes
Mar 13, 2024
tigarmo
reviewed
Mar 14, 2024
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
commented
Mar 14, 2024
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
This prevents duplicate label errors. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
mattculler
approved these changes
Mar 18, 2024
|
tests are broken |
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
sergiusens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)