Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support refresh-mode: ignore-running #4749

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Snapd 2.57 allows for a new value for refresh-mode named ignore-running

Fixes #4747

Snapd 2.57 supports a new value for refresh-mode: ignore-running

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
kenvandine added a commit to kenvandine/app-center that referenced this pull request Apr 22, 2024
This will require a snapcraft built after
canonical/snapcraft#4749 has been merged to
build.
@mr-cal mr-cal requested review from cmatsuoka and lengau April 24, 2024 13:02
snapcraft/models/project.py Show resolved Hide resolved
@mr-cal
Copy link
Collaborator Author

mr-cal commented Apr 26, 2024

I will land this today or early next week, after I release snapcraft 8.2.1.

@mr-cal mr-cal merged commit a76f85a into main Apr 29, 2024
9 of 10 checks passed
mr-cal added a commit that referenced this pull request May 9, 2024
Snapd 2.57 allows a new value for `refresh-mode` named `ignore-running`.
See snapcore/snapd@33acdb6

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal added a commit that referenced this pull request May 9, 2024
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapcraft 8.2.0.post3+gitc9ab9d1d from edge doesn't support refresh-mode: ignore-running
3 participants