Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add tests for advanced grammar in root keywords #4753

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 22, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Builds on top of #4721, so only look at the last 2 commits.

I will retarget this on a hotfix/8.x branch such that this can fit into 8.2.1.

LP#2061603
(CRAFT-2817)

@mr-cal mr-cal changed the base branch from main to hotfix/8.2 April 23, 2024 16:24
@mr-cal mr-cal force-pushed the work/CRAFT-2817-root-keywords-with-grammar branch from 410d311 to 101c8e0 Compare April 23, 2024 16:24
@mr-cal mr-cal force-pushed the work/CRAFT-2817-root-keywords-with-grammar branch from 101c8e0 to 6f9bea1 Compare April 23, 2024 19:54
@mr-cal mr-cal requested review from tigarmo and lengau April 24, 2024 18:30
@mr-cal mr-cal enabled auto-merge (squash) April 24, 2024 18:46
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-2817-root-keywords-with-grammar branch from 89df31b to fe4d258 Compare April 24, 2024 21:20
@mr-cal mr-cal merged commit 7b01ab0 into hotfix/8.2 Apr 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants