Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install gpg and dirmngr in core24 builds #4754

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Apr 23, 2024

This commit mimicks the behavior for core22<= builds where gpg and dirmngr are installed at runtime for projects with package-repositories. The trigger for this commit is the fact that the environment where Snapcraft builds in Launchpad do not have the 'dirmngr' package installed.

Unfortunately the strategy of bundling 'gpg' and 'dirmngr' as stage-packages in Snapcraft's own snap didn't work because gpg has the expected path to the 'dirmngr' executable hardcoded (always trying to call '/usr/bin/dirmngr').

Fixes #4740

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@tigarmo
Copy link
Contributor Author

tigarmo commented Apr 23, 2024

@Meulengracht can you try this PR on your failing LP build for core24? Use the edge/pr-4754 channel for snapcraft.

@tigarmo tigarmo changed the base branch from main to hotfix/8.2 April 23, 2024 15:57
@Meulengracht
Copy link
Member

Meulengracht commented Apr 23, 2024

@Meulengracht can you try this PR on your failing LP build for core24? Use the edge/pr-4754 channel for snapcraft.

Just put over a new build with the channel you suggested here

error: requested a non-existing branch on latest/edge for snap "snapcraft": pr-4754 Did I do something wrong by saying channel edge/pr-4754

@tigarmo
Copy link
Contributor Author

tigarmo commented Apr 23, 2024

No, I think the issue is that yours is an arm64 snap and our CI only publishes snapcraft builds for amd64. Do you happen to have an amd64 snap with the same issue?

This commit mimicks the behavior for core22<= builds where gpg and dirmngr
are installed at runtime for projects with package-repositories. The trigger
for this commit is the fact that the environment where Snapcraft builds in
Launchpad do _not_ have the 'dirmngr' package installed.

Unfortunately the strategy of bundling 'gpg' and 'dirmngr' as stage-packages
in Snapcraft's own snap didn't work because gpg has the expected path to the
'dirmngr' executable hardcoded (always trying to call '/usr/bin/dirmngr').

Fixes #4740
@Meulengracht
Copy link
Member

No, I think the issue is that yours is an arm64 snap and our CI only publishes snapcraft builds for amd64. Do you happen to have an amd64 snap with the same issue?

Sorry! we do not have one that is currently building on LP that is amd64 afaict for core24 that uses package-repositories

@tigarmo
Copy link
Contributor Author

tigarmo commented Apr 24, 2024

Ah that's ok, I just wanted to double-check anyway because I'm pretty sure this will fix your issue. Thanks!

@tigarmo tigarmo marked this pull request as ready for review April 24, 2024 11:18
@tigarmo tigarmo requested a review from lengau April 24, 2024 17:28
@tigarmo tigarmo merged commit 7126264 into hotfix/8.2 Apr 24, 2024
9 of 10 checks passed
@tigarmo tigarmo deleted the CRAFT-2820-bundle-dirmngr branch April 24, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package-repositories fail with the core24 base due to missing packages
4 participants