-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: install gpg and dirmngr in core24 builds #4754
Conversation
@Meulengracht can you try this PR on your failing LP build for core24? Use the edge/pr-4754 channel for snapcraft. |
5dfbb16
to
a659a2b
Compare
Just put over a new build with the channel you suggested here
|
a659a2b
to
0b888a6
Compare
No, I think the issue is that yours is an |
This commit mimicks the behavior for core22<= builds where gpg and dirmngr are installed at runtime for projects with package-repositories. The trigger for this commit is the fact that the environment where Snapcraft builds in Launchpad do _not_ have the 'dirmngr' package installed. Unfortunately the strategy of bundling 'gpg' and 'dirmngr' as stage-packages in Snapcraft's own snap didn't work because gpg has the expected path to the 'dirmngr' executable hardcoded (always trying to call '/usr/bin/dirmngr'). Fixes #4740
0b888a6
to
4938553
Compare
Sorry! we do not have one that is currently building on LP that is amd64 afaict for core24 that uses |
Ah that's ok, I just wanted to double-check anyway because I'm pretty sure this will fix your issue. Thanks! |
This commit mimicks the behavior for core22<= builds where gpg and dirmngr are installed at runtime for projects with package-repositories. The trigger for this commit is the fact that the environment where Snapcraft builds in Launchpad do not have the 'dirmngr' package installed.
Unfortunately the strategy of bundling 'gpg' and 'dirmngr' as stage-packages in Snapcraft's own snap didn't work because gpg has the expected path to the 'dirmngr' executable hardcoded (always trying to call '/usr/bin/dirmngr').
Fixes #4740
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)