Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remote-build): don't fail with certain archs #4793

Merged
merged 18 commits into from
May 9, 2024
Merged

fix(remote-build): don't fail with certain archs #4793

merged 18 commits into from
May 9, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented May 7, 2024 •
edited

This fixes the initial reported bug in #4780. However, I haven't tested some other use cases listed in that bug report.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@lengau lengau requested review from mr-cal and tigarmo May 7, 2024 22:03
tigarmo
tigarmo requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

snapcraft/utils.py Outdated Show resolved Hide resolved
snapcraft/models/project.py Outdated Show resolved Hide resolved
snapcraft/models/project.py Outdated Show resolved Hide resolved
@tigarmo
Copy link
Contributor

tigarmo commented May 8, 2024

@lengau shouldn't this PR be targeting the hotfix branch?

@lengau
Copy link
Contributor Author

lengau commented May 8, 2024

@tigarmo you're right! I'll retarget to the hotfix branch. Thanks!

@lengau lengau changed the base branch from main to hotfix/8.2 May 8, 2024 13:06
@lengau lengau requested a review from tigarmo May 8, 2024 13:08
mr-cal
mr-cal reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach. I left my main feedback as a reply in another comment.

snapcraft/models/project.py Outdated Show resolved Hide resolved
@lengau lengau requested review from mr-cal and tigarmo May 8, 2024 19:25
@lengau lengau requested a review from tigarmo May 8, 2024 19:58
tigarmo
tigarmo approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks

mr-cal
mr-cal approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lengau lengau merged commit 53ec55c into hotfix/8.2 May 9, 2024
9 of 10 checks passed
@lengau lengau deleted the CRAFT-2868/gh-4780 branch May 9, 2024 20:14
@BrewTestBot BrewTestBot mentioned this pull request May 10, 2024
Merged
1 task
@mr-cal mr-cal mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lengau @tigarmo @mr-cal