Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust login to conform to UX specification #804

Merged
merged 3 commits into from Sep 16, 2016
Merged

Adjust login to conform to UX specification #804

merged 3 commits into from Sep 16, 2016

Commits on Sep 16, 2016

  1. Adjust login to conform to UX specification 

    The store now returns an unambiguous error to indicate that two-factor
authentication is required, so we can use that to make the login process
behave how the UX specification says it should: only prompt for 2fa if
necessary, and provide a hint on a successful login without 2fa.

One obvious hack in this change is that we don't yet provide a
convenient per-store link for enabling 2fa, but instead just hardcode a
link to the SSO FAQ for now.  At the moment, people have to explicitly
opt into 2fa by joining a Launchpad team, which is a deliberate decision
because we don't have a good recovery facility and can't afford the
support bandwidth of doing manual recovery for millions of users.  When
this changes then we can also update snapcraft to do something more
graceful here, but for the moment I think this is tolerable.

LP: #1621710
    @cjwatson
    cjwatson committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    c5c3af3 View commit details
    Browse the repository at this point in the history

  2. Remove unused test path

    @cjwatson
    cjwatson committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    a3e546d View commit details
    Browse the repository at this point in the history

  3. Test another /tokens/discharge response case

    @cjwatson
    cjwatson committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    619df27 View commit details
    Browse the repository at this point in the history