Don't filter .pth files in python plugin

[ghost]

The .pth files are needed by some projects to help with importing. We
currently filter them out, breaking imports for those projects.

LP: #1626668

[ghost]

Heh. Coverage falling again. what a suprise

[sergiusens]

it is so little though

[come-maiz]

Hey @SamYaple, thanks again for your code! Do you have a simple project that fails because of this?

[ghost]

@ElOpio it failed for me with dogpile.cache, it will for you too. There are others as well that this type of import would break.

I commented on it in this patch #765

Im trying to write a quick simple project that will break like this and publish it to pypi so we can write a test against it for the future

[come-maiz]

@SamYaple yes, that would be awesome. If it's a dummy simple project, we can put it in our integration suite. If it's more complex, we can put it in our demos. ^_^

[sergiusens]

El 22/09/16 a las 15:18, Leo Arias escribió:

@SamYaple https://github.com/SamYaple yes, that would be awesome. If
it's a dummy simple project, we can put it in our integration suite.
If it's more complex, we can put it in our demos. ^_^

The reason I want it our demos is to be able to run it from the snap.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#822 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABF_5QHaDPmn9NDfHgc5WIZgZsL6j2R-ks5qssZmgaJpZM4KEKln.

[sergiusens]

ok to test

[ghost]

Lets go ahead and merge this. I have filed a tech debt bug to add an appropriate regression test for this.

https://bugs.launchpad.net/snapcraft/+bug/1626839

I dont want to hold up this fix for that test though.

[sergiusens]

I tried to this http://paste.ubuntu.com/23220251/ on an unpatched snapcraft and was able to do this http://paste.ubuntu.com/23220246/ (I am not sure how to expose the current .pth bug)

[ghost]

http://paste.ubuntu.com/23220481/

For dogpile.cache, it doesn't have the issue on python3 and version 0.6.x do not have the silly .pth usage.

I'd rather not be using dogpile.cache specifically for testing, but it is the easiest one to demonstrate at teh moment. I am working on a simple module to reproduce this.

The issue does occur on python3 as well, but that will be easier to show in a sample python project.

[sergiusens]

@SamYaple I am not questioning it doesn't happen, I was just not seeing it :-)

[ghost]

Well I can't reproduce it on python3 yet. I would like to have an example of that for reference sake. But that is what the other bug will track. I feel like this is a regression that could end up happening again.