-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-1990] README #14
Conversation
95d0dc9
to
46727c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README looks very good. I just have a suggestion to improve the Basic Usage
(and a couple of nipticks)
46727c6
to
73feb8f
Compare
73feb8f
to
1c8bb70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Coupla minor points, more suggestions than anything
- [interactive shell (Python, Scala)](https://discourse.charmhub.io/t/spark-client-snap-tutorial-interactive-mode/8954) | ||
- [programmatic access](https://discourse.charmhub.io/t/spark-client-snap-how-to-python-api/8958) | ||
|
||
## Contributing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add sections on submitting bugs and feedback; and on reporting security issues, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,92 @@ | |||
# spark8t toolkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a header mentioning that we are hiring and folks should apply at https://canonical.com/careers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
In order to look at the README nicely rendered, you could just refer to the DPE-1990_README branch