Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-1990] README #14

Merged
merged 3 commits into from
Jun 19, 2023
Merged

[DPE-1990] README #14

merged 3 commits into from
Jun 19, 2023

Conversation

juditnovak
Copy link
Contributor

@juditnovak juditnovak commented Jun 9, 2023

In order to look at the README nicely rendered, you could just refer to the DPE-1990_README branch

@juditnovak juditnovak changed the title Dpe 1990 readme [DPE-1990] readme Jun 9, 2023
@juditnovak juditnovak changed the title [DPE-1990] readme [DPE-1990] README Jun 9, 2023
@juditnovak juditnovak marked this pull request as ready for review June 9, 2023 15:41
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README looks very good. I just have a suggestion to improve the Basic Usage (and a couple of nipticks)

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link

@grobbie grobbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Coupla minor points, more suggestions than anything

- [interactive shell (Python, Scala)](https://discourse.charmhub.io/t/spark-client-snap-tutorial-interactive-mode/8954)
- [programmatic access](https://discourse.charmhub.io/t/spark-client-snap-how-to-python-api/8958)

## Contributing
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add sections on submitting bugs and feedback; and on reporting security issues, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grobbie @deusebio Is there a good "template" for that? I mean a well-formed text we already have in Canonical?

@@ -0,0 +1,92 @@
# spark8t toolkit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a header mentioning that we are hiring and folks should apply at https://canonical.com/careers

Copy link

@grobbie grobbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@deusebio deusebio merged commit c50bda8 into main Jun 19, 2023
4 checks passed
@deusebio deusebio deleted the DPE-1990_README branch June 19, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants