[DPE-2087] Improve logging handling

[deusebio]

No description provided.

[juditnovak]

I'm wondering about a different, perhaps more conventional approach.

You proposed way goes something like this:

• utility function for logger initialization and retrieval
• in each script we manually need to initialize the logger, and get the specific one we'd like to use for the script

Instead, why not:

• initialize the logging for the spark8t app at "startup" (whatever that means: first script execution/API call/etc.) --
• get the logger the traditional way:

# xyz.py module
<imports> 

logger = logging.getLogger(__name__)

I think this could be a more consistent and "bullet-proof" approach.

[juditnovak]

I strongly disagree to this solution, as

1. It goes against generic Python logging best practices together with our "internal standards" withing the Company. Typically, the concept of https://github.com/deusebio/spark-k8s-toolkit-py/blob/dpe-2087-logging-handling/spark8t/cli/params.py#L140 goes against the conventional solution of used across Canonical charms as well (*), such as

<imports>

logger = logging.getLogger(__name__)

2. I believe that logging for an application is to be initialized in a single, central, automated, "impossible-to-bypass" stage, for all interfaces/endpoints. Manually initializing logging in every single endpoint doesn't only allow for inconsistencies, but both for bugs and non-standard solutions across the same application.

Due to reason above, I'm not comfortable to give my approval here.

However, of course I understand the pressure to have the functionality available.

I recommend to go ahead my approval here, and I've opened https://warthogs.atlassian.net/browse/DPE-2138 where I'm volunteering to address the issues described above, as my next task to do.

(*) References:

• kafka-k8-operator: https://github.com/canonical/kafka-k8s-operator/blob/main/src/charm.py#L50
• opensearch-operator: https://github.com/canonical/opensearch-operator/blob/main/src/charm.py#L24
• mysql-k8-operator: https://github.com/canonical/mysql-k8s-operator/blob/main/src/charm.py#L81