[DPE-2021] integration tests lightkube registry #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juditnovak
changed the base branch from
main
to
DPE-2095_integration_tests_to_pytest
juditnovak
force-pushed
the
DPE-2021_integration_tests_lightkube_registry
branch
from
b6acd90
to
0d662d4
Compare
juditnovak
force-pushed
the
DPE-2095_integration_tests_to_pytest
branch
2 times, most recently
from
fd81bf1
to
cbf7d15
Compare
juditnovak
force-pushed
the
DPE-2021_integration_tests_lightkube_registry
branch
2 times, most recently
from
4430373
to
7bc7d7b
Compare
deusebio
approved these changes
Jun 16, 2023
marcoppenheimer
approved these changes
Jun 16, 2023
juditnovak
force-pushed
the
DPE-2095_integration_tests_to_pytest
branch
from
cbf7d15
to
8ee05e2
Compare
juditnovak
added a commit
that referenced
this pull request
Jun 16, 2023
Blindly moving from unittest to pytest, as a pre-stage to complete [DPE-2021](https://warthogs.atlassian.net/browse/DPE-2021). Related, dependent PR is #17 Stateful, "cleaning up after myself" tests not used anymore. Instead we have reliable fixtures always ensuring a clean state (in terms of namespaces). (Note: So far I see no desperate need to clean up the `default` namespace, but can be added if needed) Furthermore `tests/__init__.py` is cleaned up (none of the content was needed there). [DPE-2021]: https://warthogs.atlassian.net/browse/DPE-2021?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ While it may be difficult to review changes, note that test coverage is equal to[ the last one before this PR](https://github.com/canonical/spark-k8s-toolkit-py/actions/runs/5253123178): ``` ---------- coverage: platform linux, python 3.9.16-final-0 ----------- Name Stmts Miss Cover ------------------------------------------------------------- spark8t/__init__.py 0 0 100% spark8t/cli/__init__.py 3 3 0% spark8t/cli/params.py 29 29 0% spark8t/cli/pyspark.py 15 15 0% spark8t/cli/service_account_registry.py 76 76 0% spark8t/cli/spark_shell.py 15 15 0% spark8t/cli/spark_submit.py 15 15 0% spark8t/domain.py 161 27 83% spark8t/exceptions.py 10 1 90% spark8t/literals.py 3 0 100% spark8t/services.py 527 202 62% spark8t/utils.py 93 27 71% ------------------------------------------------------------- TOTAL 947 410 57% ================== 12 passed, 2 warnings in 138.45s (0:02:18) ================== integration: OK (144.86=setup[1.35]+cmd[3.22,0.59,139.71] seconds) congratulations :) (144.99 seconds) ``` [New execution](https://github.com/canonical/spark-k8s-toolkit-py/actions/runs/5261122237) ``` ---------- coverage: platform linux, python 3.9.17-final-0 ----------- Name Stmts Miss Cover ------------------------------------------------------------- spark8t/__init__.py 0 0 100% spark8t/cli/__init__.py 3 3 0% spark8t/cli/params.py 29 29 0% spark8t/cli/pyspark.py 15 15 0% spark8t/cli/service_account_registry.py 76 76 0% spark8t/cli/spark_shell.py 15 15 0% spark8t/cli/spark_submit.py 15 15 0% spark8t/domain.py 161 27 83% spark8t/exceptions.py 10 1 90% spark8t/literals.py 3 0 100% spark8t/services.py 527 202 62% spark8t/utils.py 93 27 71% ------------------------------------------------------------- TOTAL 947 410 57% ================== 12 passed, 2 warnings in 133.44s (0:02:13) ================== integration: OK (142.51=setup[1.63]+cmd[3.67,1.18,136.03] seconds) congratulations :) (142.66 seconds) ```
juditnovak
force-pushed
the
DPE-2021_integration_tests_lightkube_registry
branch
from
7bc7d7b
to
e100c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Not against
mainbut against #16