Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-2102] unittest to pytest #18

Merged
merged 6 commits into from
Jun 18, 2023
Merged

Conversation

juditnovak
Copy link
Contributor

@juditnovak juditnovak commented Jun 14, 2023

Moving unittests to pytest

Pipeline before unittest modifications

I'm slightly unsure what causes the 3-lines difference on the 1500+ lines test module test_services.py... But if it's preferred, I can try to find the difference. (If it's sufficiently small not to worry, then I'm also good to leave it.)

---------- coverage: platform linux, python 3.9.16-final-0 -----------
Name                                      Stmts   Miss  Cover
-------------------------------------------------------------
spark8t/__init__.py                           0      0   100%
spark8t/cli/__init__.py                       3      0   100%
spark8t/cli/params.py                        29      1    97%
spark8t/cli/pyspark.py                       15     15     0%
spark8t/cli/service_account_registry.py      76     45    41%
spark8t/cli/spark_shell.py                   15     15     0%
spark8t/cli/spark_submit.py                  15     15     0%
spark8t/domain.py                           161      7    96%
spark8t/exceptions.py                        10      2    80%
spark8t/literals.py                           3      0   100%
spark8t/services.py                         527    143    73%
spark8t/utils.py                             93     16    83%
-------------------------------------------------------------
TOTAL                                       947    259    73%

======================= 53 passed, 2 warnings in 23.55s ========================
  unit: OK (30.69=setup[1.15]+cmd[2.94,0.56,26.03] seconds)
  congratulations :) (31.23 seconds)

Current pipeline

---------- coverage: platform linux, python 3.9.16-final-0 -----------
Name                                      Stmts   Miss  Cover
-------------------------------------------------------------
spark8t/__init__.py                           0      0   100%
spark8t/cli/__init__.py                       3      0   100%
spark8t/cli/params.py                        29      1    97%
spark8t/cli/pyspark.py                       15     15     0%
spark8t/cli/service_account_registry.py      76     45    41%
spark8t/cli/spark_shell.py                   15     15     0%
spark8t/cli/spark_submit.py                  15     15     0%
spark8t/domain.py                           161      7    96%
spark8t/exceptions.py                        10      2    80%
spark8t/literals.py                           3      0   100%
spark8t/services.py                         527    146    72%
spark8t/utils.py                             93     16    83%
-------------------------------------------------------------
TOTAL                                       947    262    72%

======================= 53 passed, 2 warnings in 16.23s ========================
  unit: OK (23.84=setup[1.48]+cmd[3.48,0.75,18.12] seconds)
  congratulations :) (24.29 seconds)

@juditnovak juditnovak changed the base branch from main to DPE-2021_integration_tests_lightkube_registry June 14, 2023 14:30
@juditnovak juditnovak marked this pull request as ready for review June 14, 2023 15:52
@juditnovak juditnovak requested a review from deusebio June 14, 2023 15:52
@juditnovak juditnovak force-pushed the DPE-2021_integration_tests_lightkube_registry branch 3 times, most recently from 4430373 to 7bc7d7b Compare June 16, 2023 00:48
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me to migrate to pytest

tests/unittest/test_argument_parsing.py Outdated Show resolved Hide resolved
@juditnovak juditnovak force-pushed the DPE-2021_integration_tests_lightkube_registry branch from 7bc7d7b to e100c88 Compare June 16, 2023 15:28
Base automatically changed from DPE-2021_integration_tests_lightkube_registry to main June 16, 2023 15:49
@juditnovak juditnovak merged commit f038600 into main Jun 18, 2023
4 checks passed
@juditnovak juditnovak deleted the DPE-2102_unittest_to_pytest branch June 18, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants