-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-2102] unittest to pytest #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4430373
to
7bc7d7b
Compare
2fb4d2c
to
da4b83f
Compare
deusebio
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me to migrate to pytest
marcoppenheimer
approved these changes
Jun 16, 2023
7bc7d7b
to
e100c88
Compare
Base automatically changed from
DPE-2021_integration_tests_lightkube_registry
to
main
June 16, 2023 15:49
da4b83f
to
564a959
Compare
564a959
to
2d20750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving unittests to pytest
Pipeline before unittest modifications
I'm slightly unsure what causes the 3-lines difference on the 1500+ lines test module
test_services.py
... But if it's preferred, I can try to find the difference. (If it's sufficiently small not to worry, then I'm also good to leave it.)Current pipeline