-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-2176] Improve checks on release workflow #24
[DPE-2176] Improve checks on release workflow #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
three small commments that you might like to address, but looks fine
autorelease: | ||
name: Release the package on github | ||
needs: release-checks | ||
needs: [release_checks, tests] | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe take a pinned major version, I'm not sure what ubuntu-latest
might be. Does it mean interim releases or LTS?
outputs: | ||
version: ${{ needs.release_checks.outputs.package_version }} | ||
wheel: ${{ steps.artifact_names.outputs.wheel }} | ||
tarball: ${{ steps.artifact_names.outputs.tarball }} | ||
|
||
test: | ||
name: Test Release | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above, take the specific ubuntu 22.04 LTS version
@@ -73,7 +73,7 @@ requirements.txt: poetry.lock pyproject.toml | |||
format: setup $(files) | |||
${PYTHON} tox -e fmt | |||
|
|||
unittest: setup $(files) | |||
unittests: setup $(files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally preferred it as unittest
but might've added a hyphen as unit-test
No description provided.