Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-2745] Extent K8s key support capabilities #45

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

deusebio
Copy link
Contributor

@deusebio deusebio commented Oct 12, 2023

Keys in kubernetes secrets much comply with certain constraints and only allows characters '[-._a-zA-Z0-9]+'.

In this PR, we allows to extend the range of characters allowed by serializing/deserializing the key before storing the key, value pairs. The serialization uses a slighlty different version of the percent encoding, where the % is substituted by _

Copy link
Contributor

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a question

tests/unittest/test_utils.py Show resolved Hide resolved
@deusebio deusebio merged commit 8c36fb7 into canonical:main Oct 16, 2023
4 checks passed
@deusebio deusebio deleted the dpe-2745-k8s-key-serialization branch October 16, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poorly human-readable output when creation process fail because user already exists
2 participants