feat: adjust API link underline color and API background color #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ru-fu
reviewed
Mar 26, 2024
| @@ -8,10 +8,11 @@ body { | |||
| --color-foreground-secondary: var(--color-foreground-primary); | |||
| --color-foreground-muted: #333; | |||
| --color-background-secondary: #FFF; | |||
| --color-background-hover: #f2f2f2; | |||
| --color-background-hover: #CDCDCD; | |||
There was a problem hiding this comment.
Do you have an example for where this one is used?
| @@ -68,6 +71,8 @@ body { | |||
| --color-background-hover: #666; | |||
| --color-brand-primary: #fff; | |||
| --color-brand-content: #06C; | |||
| --color-api-background: #333; | |||
| --color-api-background-hover: #666; | |||
There was a problem hiding this comment.
A little concerned about the contrast for links with this one - but it's only on hover, so should be okay for now.
|
Covered by #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #209.
Preview
Light Mode
Before:
After:
Light Mode Hover
Before:
After:
Dark Mode
Before:
After:
Dark Mode Hover
Before:
After: