New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source: add a default value for search_drivers in POST /source #1287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running this through quick api test, the argument is still required.
File "./v2", line 152, in auto_server_install
await inst.post('/source', source_id='ubuntu-server')
File "./v2", line 83, in post
return await self.request('POST', query, data, **kwargs)
File "./v2", line 110, in request
raise ClientException(content)
__main__.ClientException: Traceback (most recent call last):
File "/home/dbungert/dev/github/canonical/subiquity/subiquity/common/api/server.py", line 115, in handler
raise TypeError(
TypeError: missing required argument "search_drivers"
Well, that does not sound right :( The following command succeeds and does what it should do.
I'm investigating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, false alarm, my test was invalid.
df01f85
to
48f8a25
Compare
No problem. I took the opportunity to add tests for it following your comment. |
For backward compatibility reasons with the desktop installer implementation, we now provide a default value (i.e., false) for the new search_drivers parameter in /source. Added non-regressions test for it. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
48f8a25
to
d981029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks from me too |
For backward compatibility reasons with the desktop installer implementation, we now provide a default value (i.e.,
false
) for the newsearch_drivers
parameter in/source
.CC @jpnurmi