ubuntu-advantage: determine on error if token was invalid #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogayot
force-pushed
the
u-a-c-distinguish-error-invalid
branch
from
750d43a
to
eca0bc4
Compare
|
CC: @lucasmoura who implemented this update in u-a-c in the first place. |
lucasmoura
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
LGTM
Marking @renanrodrigo as well since he has more knowledge about the --simulate-with-token work
dbungert
reviewed
Jul 6, 2022
In case of error, u-a-c exits with status 1. When the contract token supplied is invalid, it is also considered an error ; which previously made us unable to make the distinction between: * an invalid token * a more generic error such as network error or service unavailable error Thanks to an update in u-a-c, we can now determine if the token was invalid, by parsing the standard output of the process, even when it exits with status 1. The output is expected to be a JSON object that includes an array of errors where each error has a specific error code. The error code for an invalid token is attach-invalid-token ; which we now look for in the output to determine if the contract token was invalid. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
u-a-c-distinguish-error-invalid
branch
from
eca0bc4
to
9d6bbf2
Compare
dbungert
approved these changes
Jul 6, 2022
|
As long as you are using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of error, u-a-c exits with status 1. When the contract token supplied is invalid, it is also considered an error ; which previously made us unable to make the distinction between:
Thanks to an update in u-a-c, we can now determine if the token was invalid, by parsing the standard output of the process, even when it exits with status 1.
The output is expected to be a JSON object that includes an array of errors where each error has a specific error code.
The error code for an invalid token is
attach-invalid-token; which we now look for in the output to determine if the contract token was invalid.